Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#112] Enable GPG checks of channel artifacts #268

Merged
merged 10 commits into from
Dec 19, 2024

Conversation

spyrkob
Copy link
Contributor

@spyrkob spyrkob commented Jun 18, 2024

Fixes #112

  • Initial SignatureValidator API
  • Pass GPG setting to dependant channels
  • Update validator signatur
  • Add SignatureValidator implementation
  • Use return status instead of exceptions
  • Report validation errors
  • Add keyserver support to the validator
  • Create channel version 2.1.0

@spyrkob spyrkob marked this pull request as ready for review August 8, 2024 12:25
@spyrkob
Copy link
Contributor Author

spyrkob commented Aug 8, 2024

@jmesnil could you review this please? It's a large one, if it makes it easy I can split it up into spec/API changes and implementation PRs.

}

@JsonIgnore
public boolean requiresGpgCheck() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this method as it kind of duplicates isGpgCheck?

Copy link
Contributor Author

@spyrkob spyrkob Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it to avoid having to check isGpgCheck() for null every time, but I think it just made it more confusing, I'm happy to remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, let's store the field as a boolean and deal only once with the nullability of the Boolean param in the constructor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up keeping the field as a Boolean to allow channels without gpg-check fields to be deserialized & serialized without changes. The public getter deals with the null check

core/src/main/java/org/wildfly/channel/Channel.java Outdated Show resolved Hide resolved
doc/spec.adoc Outdated Show resolved Hide resolved
doc/spec.adoc Outdated Show resolved Hide resolved
doc/spec.adoc Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@spyrkob
Copy link
Contributor Author

spyrkob commented Sep 13, 2024

@jmesnil this should be ready for re-review, sorry about the delay. Again if it's easier I can break this down into smaller PRs (e.g. API/Spec changes vs implementation)

@spyrkob spyrkob changed the title Enable GPG checks of channel artifacts [#112] Enable GPG checks of channel artifacts Oct 29, 2024
@spyrkob
Copy link
Contributor Author

spyrkob commented Dec 2, 2024

@jmesnil would you be able to re-review the changes? I think it'd be good to get at least the channel part of this merged for WF35 so we don't have the problem with potential schema changes

Copy link
Member

@jmesnil jmesnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spyrkob This looks good apart from a few edits. Ping me when you make the change and I'll merge and release a new version. Thanks!

doc/spec.adoc Outdated Show resolved Hide resolved
doc/spec.adoc Outdated Show resolved Hide resolved
doc/spec.adoc Outdated Show resolved Hide resolved
doc/spec.adoc Outdated Show resolved Hide resolved
@spyrkob
Copy link
Contributor Author

spyrkob commented Dec 19, 2024

@jmesnil I addressed the review notes apart from the class name as it's part of bouncycastle library

@jmesnil jmesnil merged commit 52c9d15 into wildfly-extras:main Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify the integrity of components coming from channels
2 participants