Wildfly client model integration and quickstart (client) #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskacelik
force-pushed
the
wildfly-client-model-integration-and-quickstart
branch
2 times, most recently
from
9bafca5 to
51442b1
Compare
jmartisk
reviewed
Sep 3, 2024
jmartisk
reviewed
Sep 3, 2024
...m/src/main/java/org/wildfly/extension/microprofile/graphql/client/ClientModelsExtension.java
Show resolved
Hide resolved
jmartisk
reviewed
Sep 3, 2024
...nt/src/main/java/org/wildfly/extras/quickstart/microprofile/graphql/client/FilmResource.java
Outdated
Show resolved
Hide resolved
mskacelik
force-pushed
the
wildfly-client-model-integration-and-quickstart
branch
3 times, most recently
from
2e3d2c9 to
1f98778
Compare
jmartisk
reviewed
Sep 4, 2024
| final DeploymentUnit deploymentUnit = phaseContext.getDeploymentUnit(); | ||
| final CompositeIndex compositeIndex = deploymentUnit.getAttachment(Attachments.COMPOSITE_ANNOTATION_INDEX); | ||
| if(!compositeIndex.getAnnotations(GRAPHQL_CLIENT_API).isEmpty()) { | ||
| MicroProfileGraphQLClientLogger.LOGGER.multipleGraphQLApiAnnotations(); |
There was a problem hiding this comment.
I don't get this, this says that we found "multiple" annotations, but will appear even if there's just one, no? What's the point of this logging message?
There was a problem hiding this comment.
Ok, I had on my mind "multiple" as in one or more annotations.
mskacelik
force-pushed
the
wildfly-client-model-integration-and-quickstart
branch
2 times, most recently
from
d60bbf8 to
b5f9073
Compare
jmartisk
reviewed
Sep 4, 2024
pom.xml
Outdated
| @@ -51,7 +51,7 @@ | |||
| the built feature pack. --> | |||
| <version.io.smallrye.graphql>2.9.1</version.io.smallrye.graphql> | |||
| <version.org.eclipse.microprofile.graphql>2.0</version.org.eclipse.microprofile.graphql> | |||
| <version.com.graphql-java>22.1</version.com.graphql-java> | |||
| <version.com.graphql-java>22.2</version.com.graphql-java> | |||
There was a problem hiding this comment.
Let's remove this for now please, we'll do this along with upgrading to sr-gql 2.10.0 next week. Otherwise, all looks good to me!
mskacelik
force-pushed
the
wildfly-client-model-integration-and-quickstart
branch
from
b5f9073 to
d937361
Compare
jmartisk
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @jmartisk