Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUD-4211 Cloud clustering profiles should configure a distributed caches instead of a replicated ones #397

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

rhusar
Copy link
Contributor

@rhusar rhusar commented Jun 6, 2024

@jfdenise
Copy link
Collaborator

@rhusar , there is a failing test. We are looking for the content "default-cache="repl""
there: https://github.com/wildfly-extras/wildfly-jar-maven-plugin/blob/main/tests/src/test/java/org/wildfly/plugins/bootablejar/maven/goals/DefaultCloudConfigurationTestCase.java#L51
This would have to be updated to reference a token in the config that is specific to the cloud configuration.

@rhusar
Copy link
Contributor Author

rhusar commented Jun 17, 2024

@jfdenise Ah, thanks, will fix that - but it's hard to see what's failing since tests are failing both locally and on CI in main as well (latest push c1b0b0e)

@jfdenise
Copy link
Collaborator

@rhusar is still in the plan? Could you rebase your branch, thank-you.

@rhusar
Copy link
Contributor Author

rhusar commented Nov 29, 2024

@rhusar is still in the plan? Could you rebase your branch, thank-you.

Will do, thanks for the ping @jfdenise

@jfdenise
Copy link
Collaborator

@rhusar , do you want it in 12.0.0.Final? Would you mind rebasing and e-run the tests? Thank-you.

@rhusar
Copy link
Contributor Author

rhusar commented Dec 18, 2024

@jfdenise Yes, will do that shortly today!

@rhusar rhusar marked this pull request as ready for review December 18, 2024 12:05
@rhusar rhusar requested a review from jfdenise as a code owner December 18, 2024 12:05
@rhusar
Copy link
Contributor Author

rhusar commented Dec 18, 2024

Sigh... the CI won't run as I am not a member of wildfly-extras.

@rhusar
Copy link
Contributor Author

rhusar commented Dec 18, 2024

@pferraro Could you please review? Thanks!

Copy link
Contributor

@pferraro pferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfdenise jfdenise merged commit 0347ce0 into wildfly-extras:main Dec 18, 2024
8 checks passed
@jfdenise
Copy link
Collaborator

@rhusar thank-you, merged.

@rhusar rhusar deleted the CLOUD-4211 branch December 18, 2024 14:47
@rhusar
Copy link
Contributor Author

rhusar commented Dec 18, 2024

@rhusar thank-you, merged.

Thanks and sorry for the delay on this as I was working in a whole different area :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants