Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cmd/cluster in Dockerfile #95

Closed
ohkinozomu opened this issue Jul 25, 2024 · 2 comments · Fixed by #96
Closed

Include cmd/cluster in Dockerfile #95

ohkinozomu opened this issue Jul 25, 2024 · 2 comments · Fixed by #96

Comments

@ohkinozomu
Copy link
Contributor

Hello,

I noticed that the Dockerfile does not include cmd/cluster.
Is there any consideration for creating a Dockerfile that includes cmd/cluster?

Option 1:
Include cmd/cluster in the current Dockerfile. In this case, the size increases from 15.6 MB to 32.8 MB.

Option 2:
Create a separate Dockerfile, for example, Dockerfile.cluster.

Which option is preferable?
I prefer Option 1, but if size is an issue, Option 2 should be considered.

@wind-c
Copy link
Owner

wind-c commented Jul 25, 2024

Why such a big difference in size?

@ohkinozomu
Copy link
Contributor Author

Sorry, I was referring to the Virtual size value in Google Artifact Registry, which is defined as "Compressed total image size to be downloaded over the network." This seems to be different from the local container image size.

Here are the actual details:

REPOSITORY       TAG               IMAGE ID       CREATED         SIZE
comqtt-tobe      latest            b44b748866c6   4 seconds ago   69.8MB
comqtt-current   latest            e0d5e6f60bcf   3 minutes ago   33.1MB

The difference is simply the binary size of comqtt-cluster.

/ # ls -alh
......
-rwxr-xr-x    1 root     root       24.1M Jul 25 22:28 comqtt
-rwxr-xr-x    1 root     root       35.0M Jul 25 22:29 comqtt-cluster

The Dockerfile I created is as shown in #96

@wind-c wind-c closed this as completed in #96 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants