testCluster: Add etcd integration tests #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we don't remove p.Stop, because p.Stop is called twice, The entry point for the stop process is p.Stop, where p.proposeC and p.confChangeC are closed, which in turn closes p.stopC. I think this wasn't an issue before because p.stopC was not being closed. |
|
I am not sure about the result after deletion, let me comment first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In peer.go, there was an issue where stopC should close when proposeC and confChangeC are closed, but proposeC and confChangeC were not being closed.
I have fixed this.