Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poor sedmv2 photometry #371

Open
saarahhall opened this issue May 11, 2023 · 6 comments · Fixed by #426
Open

poor sedmv2 photometry #371

saarahhall opened this issue May 11, 2023 · 6 comments · Fixed by #426
Assignees
Labels
bug Something isn't working catalogs Related to catalogs nearfuture not required now, but will be important soon processors Related to processors SEDMv2 Related to SEDv2

Comments

@saarahhall
Copy link
Collaborator

Describe the bug
There is some room for improvement on sedmv2 photometry outputs - some bogus/saturated/edge sources are messing with the zero-point calculation in PhotCal.py. To address this, when calculating the zero-point we should:

  • Exclude PS1 reference sources that are flagged as saturated (this should be the default behavior for all instruments)
  • Exclude sources detected on the edge of the IFU mask for sedmv2
@saarahhall saarahhall added bug Something isn't working nearfuture not required now, but will be important soon processors Related to processors catalogs Related to catalogs SEDMv2 Related to SEDv2 labels May 11, 2023
@saarahhall saarahhall self-assigned this May 11, 2023
@broulston
Copy link
Collaborator

@saarahha for the second point about excluding sources at the IFU mask edges, are you planning on implementing that using sourceextractor? I know the PSF photometry is failing primarily because it's trying to build PSF models which include bogus sources at the IFU mask edge. The sourceextrator catalog is remade for the PSF step so any fix would likely need to be in the sourceextractor processor. I was going to look at this but if you already are great! Let me know if you need any help! 😀

@saarahhall
Copy link
Collaborator Author

@broulston Great minds think alike... I will give this a try today within sourceextractor, and I'll let you know!

@saarahhall
Copy link
Collaborator Author

  • should also address the recent issue where the first frame of SEDMv2 MEFs looks faulty. throw the first frames away after MultiExtParser?

@virajkaram
Copy link
Collaborator

Reopening because this was reverted by #412 . Will be fixed in a separate PR.

@virajkaram virajkaram reopened this Jun 30, 2023
@robertdstein
Copy link
Member

Sorry Saarah!

@virajkaram

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working catalogs Related to catalogs nearfuture not required now, but will be important soon processors Related to processors SEDMv2 Related to SEDv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants