Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust candidate broadcasting #898

Merged
merged 6 commits into from
May 18, 2024
Merged

More robust candidate broadcasting #898

merged 6 commits into from
May 18, 2024

Conversation

robertdstein
Copy link
Member

This PR increases robustness/improves fallbacks of candidate broadcasting:

  • It extends the timeout window in penquins from default 5s to 600s, for source crossmatching
  • It groups sources in batches of 1 for source crossmatching via Kowalski, so that a timeout would affect only a single source table
  • It sets a limit of 4 threads for crossmatching API calls, to avoid inadvertent DDOS attacks with 40 threads 😅
  • It better allows sources to be resent to skyportal via API rather than IPAC. That was possible before, but should now be much closer to normal IPAC-style candidates: annotations are now identical, and all candidates sent via API are marked in the db as sent.
  • Adds more flexibility for annotations. Now passed as an argument to skyportal processors, and includes rb score for WINTER.

@robertdstein robertdstein enabled auto-merge (squash) May 18, 2024 01:14
@coveralls
Copy link

coveralls commented May 18, 2024

Pull Request Test Coverage Report for Build 9136150094

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 11 of 15 (73.33%) changed or added relevant lines in 4 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 84.613%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mirar/processors/skyportal/skyportal_candidate.py 6 10 60.0%
Files with Coverage Reduction New Missed Lines %
mirar/processors/sources/source_selector.py 6 58.24%
Totals Coverage Status
Change from base Build 9103899040: -0.04%
Covered Lines: 10954
Relevant Lines: 12946

💛 - Coveralls

@robertdstein robertdstein merged commit 7d7b08f into main May 18, 2024
15 of 17 checks passed
@robertdstein robertdstein deleted the rebatchcandidates branch May 18, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants