Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separately track whether observations are attempted vs completed #130

Open
2 tasks
nlourie opened this issue May 31, 2024 · 0 comments
Open
2 tasks

separately track whether observations are attempted vs completed #130

nlourie opened this issue May 31, 2024 · 0 comments
Assignees

Comments

@nlourie
Copy link
Contributor

nlourie commented May 31, 2024

Errors during observations (eg a rotator error) cause observations to get skipped. This is because observations are marked as completed once they are loaded. Add a new field that gets written to the schedules for attempted which increments a counter for the number of times it is attempted.

  • Simplest fix: the easiest approach here is to let things get attempted up to N times (2?)
  • Fancier fix: record the number of dithers actually executed so that on subsequent loads it will only do the remaining dithers.

I think we need both of these, because we need to still ensure that no observation gets stuck in an infinite loop where it is continually loaded and failed.

The preferred logic is:

  • load observation, increment attempted from 0 --> 1
  • increment completed dithers after each completed dither
  • only once all dithers are completed set completed from 0 --> 1
@nlourie nlourie self-assigned this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant