Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ocrignore file support #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

feliperyan
Copy link

Added support for a ignore file similar to .gitignore in order for users to exclude unwanted files such as .DS_Store etc.

The file should be in the pwd and named .ocrignore

@wintermi
Copy link
Owner

Thanks @feliperyan for the PR.

With the latest release - v0.2.0 - we added file extension filtering, so I do not think that this is required any longer. What's your thoughts?

@feliperyan
Copy link
Author

Hey @wintermi totally up to you mate, I'm not precious. The one obvious use case is if the user has a messy dir with mixed image types and wants to exclude some, or a dir tree where only certain folders need to be excluded.

@wintermi
Copy link
Owner

Agreed, there are benefits. The PR needs to be aligned with the restructuring made for v0.2.0. Also, rather than use .ocrignore in pwd, it would be better IMO to add an extra argument, e.g. --ignore <filename>. This would make it easier to use in automation scripts. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants