feat(clamav): Make config files dict values #536
Conversation
|
I didn't bump the version of the chart as to not cause a merge conflict with my other open PR for clamav. |
jplitza
force-pushed
the
clamav-config-dict
branch
2 times, most recently
from
b4fb5b1
to
ba7ea75
Compare
This allows for fine-grained overrides of the default values provided with the Helm chart. It should fall back gracefully when there are local values of the old string type.
jplitza
force-pushed
the
clamav-config-dict
branch
from
ba7ea75
to
226dee9
Compare
|
Of course there were merge conflicts anyway (in the values.yaml). Rebased, and bumped the Chart version now, too. Also fixed a duplicate key in the YAML (good thing I designed the templates to handle list values 😄), outsourced the dict-to-config translation to a helper template and fixed some YAML shenanigans. BTW, your CI pipeline spawns several (3?) instances of the pod. Since you are using the _base version of the ClamAV image, which doesn't contain the database, this causes 3 downloads of the database (several 100 MB) from the ClamAV CDN. You may consider using the image version without _base, to only download the database once, together with the image. |
This allows for fine-grained overrides of the default values provided with the Helm chart.
It should fall back gracefully when there are local values of the old string type.