Fix foreach ending on tables with type mismatch #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2803
This repeats the iter in a loop until a type match or nil.
This might be better as a fix in the rcompiler to run typecheck in the loop, so as to preserve the intent of
iter. Unfortunately, despite my attempts, I can't find a way to safely put the responsibility on the compiler instead.If I had the approval to change the signature of operator
iterto includetypeat the end, it would be terribly easy to move into the compiler instead, however passing type is also a bit heavyhanded of an approach.