Improve user-generated entity/wirelink outputs #2891
Conversation
- Add output remover - Made adding entity and wirelink outputs more sensible - Cleaned up port assignment to not give bad indices - Removed using CreateWirelinkOutput when it's not necessary - Removed E2 `entity:wirelink()` creates a wirelink output - ??? other magic to make this work
There was a problem hiding this comment.
Could we do something like shift+r with the wire tool removes outputs? Making a whole new tool for this is kind of messy.
There was a problem hiding this comment.
I guess so. I didn't want to touch the wire tool because I figured it had enough features.
Refactored wire_adv netcode to use a single networkstring
|
I think it looks okay. Not sure if it will break addon compatibility |
I doubt any addon is using anything here in an unsafe way. Net messages part is more just for safety in case. |
|
| if not self.entity.extended then | ||
| WireLib.CreateWirelinkOutput( self.player, self.entity, {true} ) | ||
| end |
There was a problem hiding this comment.
#2940, just posting review to make it official
Well at least there is one addon I know off that could get issues. The removal of the wirelink output breaks the "isWired" detection needed in the entity of my project. This will lead e2 wirelinks to no longer work with it. More details: Grocel/3D-Stream-Radio#20 |
The solution you use is not a good indicator of wirelinks being used. You'll need to work around the fact that wirelinks can ignore wires.
|
Yeah, I know. Wiremod had nothing else I could have used for that. Is was somewhat ok to use for my use case, though.
As seen in #2942. I need something like this, thanks. |
Simple facelift to user-generated ("Create Entity") outputs.
wire_advnetworking to use a single networkstringWireLib.CreateWirelinkOutputwhen it's not necessaryentity:wirelink()creates a wirelink outputFixes #2888