-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Started wire entity memory sync class #2979
Conversation
Is this meant to be a replacement for NetworkVars? |
No, it's for entities that sync their 'memory' variable to client |
The only problem I foresee with my current approach is that it doesn't preserve write order or writing over a memory address multiple times, which I imagine may cause bugs in some entities. Maybe need to remove those optimizations. |
Or maybe make a WireLib.MemoryTrackerPreserveOrder version of WireLib.MemoryTracker |
This pull request has been marked as stale as there haven't been any changes in the past month. It will be closed in 15 days. |
This pull request has been marked as stale as there haven't been any changes in the past month. It will be closed in 15 days. |
Not really happy with this. I think I should've done a queue per entity instead of globbing all the entity data together. Also I don't have the energy to do the memory playback management for each entity that syncs its memory. |
Will also require stringstream class