Fix RT Camera OnRemove detection #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denneisk
approved these changes
Apr 2, 2024
I guess let us know when sure |
|
Seems like its in the base game, rubat just removed the warning from the wiki after i asked about it https://wiki.facepunch.com/gmod/ENTITY:OnRemove~diff:561626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ObservedCamerasIndexisn't fully cleared which can cause RT material leakage.After talking with @stepa2 he localized the issue to be in OnRemove which this PR fixes.
This also fixes the console command
wire_rt_camera_recreateerroring.The argument passed into OnRemove should be available on gmod main branch too but it's not entirely clear on the wiki, i've aksed the gmod devs to be sure.