Fix Friends List would limit to 4 outputted friends #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denneisk
changed the title
thegrb93
reviewed
Apr 9, 2024
| local ply = plys[i] | ||
| local steamid = ply:SteamID() | ||
|
|
||
| if self.friends_lookup[ply] then return end |
There was a problem hiding this comment.
Bad early return. Should be 'continue'
There was a problem hiding this comment.
Ah thanks, copying error.
thegrb93
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WireLib.TriggerOutputhas an execution limit of 4.UpdateFriendsListcallsConnectedwhich callsUpdateOutputswhich can trigger more than 4 times (and is extremely redundant).This avoids calling the
Connectedmethod inUpdateFriendsListby inlining all the relevant parts.