Throw error if holo index is NaN #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegrb93
requested changes
Sep 9, 2024
| local function CheckIndex(self, index, shouldbenil) | ||
| index = math.Clamp(math.floor(index), -2^31, 2^31) | ||
| if index ~= index then return self:throw("holo index is NaN!", 0) end |
There was a problem hiding this comment.
The default in this throw should be nil instead of 0 I think
thegrb93
requested changes
Sep 9, 2024
The new local is unnecessary Co-authored-by: thegrb93 <grbrown93@sbcglobal.net>
Remove local Co-authored-by: thegrb93 <grbrown93@sbcglobal.net>
thegrb93
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the title explains the change.
If you use, for instance,
holoCreate(0/0), Expression2 will throw a Lua error. It might be difficult for e2 users to figure out whats wrong with their code, so just throw an Expression2 error.Ignore the other commits, I changed my mind how to fix the problem, while I was fixing it.