Micro-optimizations for base_wire_entity #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denneisk
approved these changes
Nov 30, 2024
thegrb93
requested changes
Dec 1, 2024
Comment on lines
287
to
298
| function ENT:Think() | ||
| if (CurTime() >= (self.NextRBUpdate or 0)) then | ||
| local tab = self:GetTable() | ||
|
|
||
| if (CurTime() >= (tab.NextRBUpdate or 0)) then | ||
| -- We periodically update the render bounds every 10 seconds - the | ||
| -- reasons why are mostly anecdotal, but in some circumstances | ||
| -- entities might 'forget' their renderbounds. Nobody really knows | ||
| -- if this is still needed or not. | ||
| self.NextRBUpdate = CurTime() + 10 | ||
| tab.NextRBUpdate = CurTime() + 10 | ||
| Wire_UpdateRenderBounds(self) | ||
| end | ||
| end |
There was a problem hiding this comment.
Need to investigate if this is even needed code anymore
Co-authored-by: thegrb93 <grbrown93@sbcglobal.net>
|
I don’t understand why cancel all optimizations for :GetTable. It’s not part of the ENTITY metatable and can be used safely. I also don’t see the point in removing vector optimizations, as all they do is prevent creating new vectors. |
|
Crap code for a pinch of performance. Entity __index does GetTable itself so its not that beneficial in places where you're only avoiding one __index call |
|
I was also questioning if |
thegrb93
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically just saves __index calls/caches colors