Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new E2 hash functions #3199

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Add new E2 hash functions #3199

merged 4 commits into from
Dec 4, 2024

Conversation

Denneisk
Copy link
Member

@Denneisk Denneisk commented Dec 3, 2024

  • Adds hashCRC(string) to get the CRC checksum of a string
  • Adds hashMD5(string) to get the MD5 hash of a string
  • Adds hashSHA1(string) to get the SHA1 hash of a string
  • Adds hashSHA256(string) to get the SHA256 of a string
  • Update test file to include hash functions
  • Update hash(string) description
  • Deprecates hash(string)

I think the size limit could be higher without much concern. Please advise.

Also doing this as a test of the linter since for some reason it's using the old one on the other PR.

@Denneisk
Copy link
Member Author

Denneisk commented Dec 4, 2024

Changing to forceThrow because I want to avoid new E2 functions having default returns.

@thegrb93
Copy link
Contributor

thegrb93 commented Dec 4, 2024

Yeah woops. I also forgot e2's throw only throws while strict

@thegrb93 thegrb93 merged commit 79f1429 into wiremod:master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants