Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for multiple pronouns #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

egefeyzioglu
Copy link

Resolves #117 . No feature added so no new testing necessary, everything already covered by existing tests (which have no reason to fail.)

@zaquestion
Copy link

This is great @morganastra can this be brought in? I actually sat down to try and add a feature like this and didn't realize it existed until a last minute double check of the issue tracker.

I'd actually prefer if the site didn't require the additional keyword and just accepted pronoun.is/they/he with the same behavior, but pronoun.is/they/:or/he is a much appreciated syntax!

@kalikiana
Copy link

http://pronoun.is/they/.../themself/:or/he/:or/her doesn't seem to work correctly, I only see 2 out of 3 pronouncs 🤔

@egefeyzioglu
Copy link
Author

Added that as an issue, see #129

Copy link

@arimgibson arimgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both changes look good and work in production. Can be viewed at https://pronounis.herokuapp.com for the time being, will be taken down when PR is merged.

cc: @egefeyzioglu @morganastra

@kevindigo
Copy link

It would be great to get this merged. I came to the issue tracker to request support for multiple pronouns, was happy to see that it was already supported, and that an MR was already up to document it. I was then disappointed to see that it went almost a year unmerged, but am happy to see recent activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation missing for multiple pronouns
5 participants