fix: add_hook and add_test handling #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in an flat test file:
for some weird reason gets assigned to a hook, and not to ROOT_DESCRIBE_BLOCK, like I'd expect initially.
It turned out that my handling of
add_hook
andadd_test
was slightly incorrect – they should not permanently setcurrentMetadata
to a test/hook definition.So, what I'm doing now is to set a special listener which fires last and re-focuses the current metadata to the current describe block. This should help.