Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint plugin - initial refactor + reintroduce test of graph with a subgraph #141

Merged
merged 6 commits into from
Jun 16, 2024
Merged

ESLint plugin - initial refactor + reintroduce test of graph with a subgraph #141

merged 6 commits into from
Jun 16, 2024

Conversation

guyca
Copy link
Collaborator

@guyca guyca commented Jun 14, 2024 •
edited
Loading

This PR slightly refactors the eslint-plugin-obsidian package.

  1. Tests were moved to a separate folder
  2. file path resolving logic was refactored into a separate class and is now mocked in tests.
  3. Reintroduced the subgraph test. It was disabled due to an issue resolving files in tests.

@guyca guyca requested a review from orlyd June 15, 2024 13:49
@guyca guyca changed the title Refactor ESLint plugin ESLint plugin - initial refactor + reintroduce test of graph with a subgraph Jun 15, 2024
@orlyd orlyd merged commit 76b5dba into master Jun 16, 2024
2 checks passed
@orlyd orlyd deleted the refactorEslintPlugin branch June 16, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlyd orlyd orlyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guyca @orlyd