add goup active index and group navigation to panel api #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhattav
reviewed
Jul 9, 2023
| @@ -882,6 +882,9 @@ class SlideshowView extends React.Component { | |||
| getActiveItemIndex: () => { | |||
| return this.state.activeIndex; | |||
| }, | |||
| getActiveGroupIndex: () => { | |||
| return this.getCenteredItemOrGroupIdxByScroll('groups'); | |||
There was a problem hiding this comment.
Why would this be different than line 883?
Why isnt this a state? this calculation should not be triggered by request, but by change.
| @@ -892,6 +895,20 @@ class SlideshowView extends React.Component { | |||
|
|
|||
| this.props.actions.eventsListener(GALLERY_CONSTS.events.ITEM_ACTION_TRIGGERED, props, e); | |||
| }, | |||
| scrollToGroupIndex: (idx) => { | |||
There was a problem hiding this comment.
When is this used? Please add a description on the PR.
There was a problem hiding this comment.
Adding Group Active Index and Group Navigation to the Panel API would be a fantastic enhancement! This feature could streamline navigation and provide developers with better control over grouped components, ensuring a smoother user experience and more organized UI management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.