fix scroll to first video on autoplay #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liatv
reviewed
Feb 15, 2024
| @@ -59,7 +59,7 @@ export default class ScrollIndicator extends React.Component { | |||
| this.onHorizontalScroll = (e) => { | |||
| this.props.setGotFirstScrollIfNeeded(); | |||
| const target = e.currentTarget || e.target || e; | |||
| let left = target && (target.scrollX || target.scrollLeft || target.x); | |||
| let left = target && (target.scrollX || target.scrollLeft !== undefined ? target.scrollLeft : target.x); | |||
There was a problem hiding this comment.
Suggested change
| let left = target && (target.scrollX || target.scrollLeft !== undefined ? target.scrollLeft : target.x); | |
| let left = target && (target.scrollX || target.scrollLeft ?? target.x); |
There was a problem hiding this comment.
@liatv changed both
IzaacAyelin
approved these changes
Feb 15, 2024
noam-heller1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is for desktop and mobile.
left was undefined when target.scrollLeft = 0 and target.x = undefined, so it didn't triggered the scroll.