Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix video not playing in expand mode on safari #1189

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

noam-heller1
Copy link
Contributor

when multiple elements have the same id, Safari selectors return the first element with that id.

Jira ticket: https://jira.wixpress.com/browse/PG-422
Monday Item: https://wix.monday.com/boards/5762041197/pulses/6042196244

Copy link
Contributor

@liatv liatv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@noam-heller1 noam-heller1 merged commit c065649 into master Feb 22, 2024
7 checks passed
@noam-heller1 noam-heller1 deleted the fix-expand-mode-video-safari branch February 22, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants