Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Styling Elements with CSS.md #3017

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

christopherbWIX
Copy link
Contributor

@christopherbWIX christopherbWIX commented Jul 2, 2024

Monday bug: https://wix.monday.com/boards/892806647/pulses/6918701795?notification=4794297213

Moved the classes from the element mixin article to the general article as the elements article is going to be hidden. See Monday bug for details.

@@ -94,7 +94,141 @@ For reference, here is a list of global classes:
- [Time picker](/time-picker/css-classes)
- [Upload button](/upload-button/css-classes)
- [Vector image](/vector-image/css-classes)
- [Vertical line]($w/element/css-classes#vertical-line)
- [Vertical line](#vertical-line)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it need to be #vertical-classes?

- [Video player](/video-player/css-classes)

The following classes are can be customized but don't have an associated $w API:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"are" should be removed.

#### `.image-button`

Targets image button elements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reading this, I thought that it's a compound noun "Target image button elements" with a grammar error instead of a sentence without a subject. Maybe we could use the verb affect/affects? But it could also just be me, so feel free to ignore.

@christopherbWIX christopherbWIX merged commit 65e7212 into master Jul 2, 2024
1 check passed
@christopherbWIX christopherbWIX deleted the christopherbWIX-patch-1 branch July 2, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants