Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Effects Mixin - Remove Editor X #3074

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

ryangec
Copy link
Contributor

@ryangec ryangec commented Jul 31, 2024

ryangec and others added 3 commits July 31, 2024 11:03
changes:
Service $w.Effects has changed summary
Service $w.Effects has changed description
Service $w.Effects property activeEffects has changed description
Service $w.Effects property allEffects has changed description
Service $w.Effects operation applyEffects has changed description
Service $w.Effects operation removeAllEffects has changed description
Service $w.Effects operation removeEffects has changed description
Service $w.Effects operation toggleEffects has changed description
Service $w.EffectsMixin has changed summary
Service $w.EffectsMixin has changed description
Service $w.EffectsMixin property effects has changed summary
Service $w.WixComments operation onCommentCreate.examples[0] has changed body

issues:
Message ViewChangeEventOptions has an unknown property type * (ApppointmentFieldEvent.js (8))
Property target is missing a type annotation (GalleryNavigationStartEvent.js (15))
Operation postMessage has an unknown param type * (HtmlComponent.js (97))
Property data has an unknown type * (HtmlComponentMessageEvent.js (17))
Property fileLimit has mismatching types for get (number) and set (string) (UploadButton.js (128, 149))
Operation set has an unknown param type * (window-frontend.js (201))
Operation get has an unknown return type * (window-frontend.js (234))
Operation set has an unknown param type * (window.js (235))
Operation get has an unknown return type * (window.js (269))
Callback ViewChangeOperation is defined two or more times (AppointmentField.js (347), DatePicker.js (472))
Callback ViewChangeOperation has an unknown return type * (AppointmentField.js (347))
Callback ViewChangeEventHandler is defined two or more times (AppointmentField.js (362), DatePicker.js (466))
Callback Validator has an unknown param type * (ValidatableMixin.js (143))
Property value has an unknown type * (ValueMixin.js (62))
Property value has an unknown type * (ValueMixin.js (89))
@ryangec ryangec merged commit 56915fd into master Jul 31, 2024
1 check passed
@ryangec ryangec deleted the editor-x-effects-note branch July 31, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant