Managed adapter lint fixes (#462)

wix · Oct 31, 2023 · 54c714c · 54c714c
1 parent a0e9a01
commit 54c714c
Show file tree

Hide file tree

Showing 57 changed files with 73 additions and 78 deletions.
diff --git a/libs/external-db-airtable/src/sql_filter_transformer.spec.ts b/libs/external-db-airtable/src/sql_filter_transformer.spec.ts
@@ -144,7 +144,7 @@ describe('Sql Parser', () => {
                 const filter = {
                     operator: eq,
                     fieldName: ctx.fieldName,
-                    value: value
+                    value
                 }
 
                 expect( env.filterParser.parseFilter(filter) ).toEqual([{

diff --git a/libs/external-db-airtable/tests/drivers/mock_air_table.js b/libs/external-db-airtable/tests/drivers/mock_air_table.js
@@ -55,7 +55,7 @@ const batchRecordUpdate = [
                 const fields = req.body.typecast ? { typecasted: true } : record.fields
                 return {
                     id: record.id,
-                    fields: fields,
+                    fields,
                 }
             }),
         })

diff --git a/libs/external-db-airtable/tests/e2e-testkit/airtable_resources.ts b/libs/external-db-airtable/tests/e2e-testkit/airtable_resources.ts
@@ -10,7 +10,7 @@ export const connection = async() => {
     const { connection, schemaProvider, cleanup } = await init(connectionConfig(),
         { requestTimeout: 1000 })
 
-    return { pool: connection, schemaProvider, cleanup: cleanup }
+    return { pool: connection, schemaProvider, cleanup }
 }
 
 export const cleanup = async() => {

diff --git a/libs/external-db-bigquery/src/sql_filter_transformer.spec.ts b/libs/external-db-bigquery/src/sql_filter_transformer.spec.ts
@@ -178,7 +178,7 @@ describe('Sql Parser', () => {
                 const filter = {
                     operator: eq,
                     fieldName: ctx.fieldName,
-                    value: value
+                    value
                 }
 
                 expect( env.filterParser.parseFilter(filter) ).toEqual([{

diff --git a/libs/external-db-bigquery/src/sql_filter_transformer.ts b/libs/external-db-bigquery/src/sql_filter_transformer.ts
@@ -57,7 +57,7 @@ export default class FilterParser {
             fieldsStatement: filterColumnsStr.join(', '),
             groupByColumns,
             havingFilter: filterExpr,
-            parameters: parameters,
+            parameters,
         }
     }
 
@@ -74,8 +74,7 @@ export default class FilterParser {
     }
 
     extractFilterExprAndParams(havingFilter: any[]) {
-        return havingFilter.map(({ filterExpr, parameters }) => ({ filterExpr: filterExpr !== '' ? `HAVING ${filterExpr}` : '',
-                                                                    parameters: parameters }))
+        return havingFilter.map(({ filterExpr, parameters }) => ({ filterExpr: filterExpr !== '' ? `HAVING ${filterExpr}` : '', parameters }))
                            .concat(EmptyFilter)[0]
     }
 

diff --git a/libs/external-db-bigquery/tests/drivers/db_operations_test_support.ts b/libs/external-db-bigquery/tests/drivers/db_operations_test_support.ts
@@ -12,7 +12,7 @@ const dbOperationWithMisconfiguredDatabaseId = () => new DatabaseOperations(crea
 export const dbOperationWithValidDB = () => {
     const { connection, cleanup } = createPool({ databaseId: 'testDB' })
     const dbOperations = new DatabaseOperations(connection)
-    return { dbOperations, cleanup: cleanup }
+    return { dbOperations, cleanup }
 }
 
 export const misconfiguredDbOperationOptions = () => ([   ['pool connection with wrong databaseId', () => dbOperationWithMisconfiguredDatabaseId()]])
diff --git a/libs/external-db-bigquery/tests/drivers/sql_filter_transformer_test_support.ts b/libs/external-db-bigquery/tests/drivers/sql_filter_transformer_test_support.ts
@@ -42,7 +42,7 @@ export const givenAggregateQueryWith = (having: any, numericColumns: { name: any
     when(filterParser.parseAggregation).calledWith({ postFilteringStep: filter, processingStep: having })
                                        .mockReturnValue({
                                            fieldsStatement: `${groupByColumns.map( escapeIdentifier ).join(', ')}, MAX(${escapeIdentifier(numericColumns[0].name)}) AS ${escapeIdentifier(columnAliases[0])}, SUM(${escapeIdentifier(numericColumns[1].name)}) AS ${escapeIdentifier(columnAliases[1])}`,
-                                           groupByColumns: groupByColumns,
+                                           groupByColumns,
                                            offset: offest,
                                            havingFilter: '',
                                            parameters: [],

diff --git a/libs/external-db-config/src/readers/aws_authorization_config_reader.ts b/libs/external-db-config/src/readers/aws_authorization_config_reader.ts
@@ -32,6 +32,6 @@ export default class AwsAuthorizationConfigReader implements IConfigReader {
     const { externalConfig, secretMangerError }: {[key:string]: any} = await this.readExternalConfig()
     const { PERMISSIONS }: { PERMISSIONS: any } = { ...process.env, ...externalConfig }
     const config = { PERMISSIONS }
-    return { config, secretMangerError: secretMangerError }
+    return { config, secretMangerError }
   }
 }
diff --git a/libs/external-db-config/src/readers/aws_config_reader.ts b/libs/external-db-config/src/readers/aws_config_reader.ts
@@ -14,7 +14,7 @@ export class AwsConfigReader implements IConfigReader {
   async readConfig() {
     const { config } = await this.readExternalAndLocalConfig()
     const { host, username, password, DB, EXTERNAL_DATABASE_ID, ALLOWED_METASITES, DB_PORT } = config
-    return { host: host, user: username, password: password, db: DB, externalDatabaseId: EXTERNAL_DATABASE_ID, allowedMetasites: ALLOWED_METASITES, port: DB_PORT }
+    return { host, user: username, password, db: DB, externalDatabaseId: EXTERNAL_DATABASE_ID, allowedMetasites: ALLOWED_METASITES, port: DB_PORT }
   }
 
   async readExternalConfig() {
@@ -56,7 +56,7 @@ export class AwsDynamoConfigReader implements IConfigReader {
       const { EXTERNAL_DATABASE_ID = undefined, ALLOWED_METASITES = undefined } = { ...process.env, ...externalConfig }
       const config = { EXTERNAL_DATABASE_ID, ALLOWED_METASITES }
 
-      return { config, secretMangerError: secretMangerError }
+      return { config, secretMangerError }
     }
 
     async readExternalConfig() {
@@ -93,7 +93,7 @@ export class AwsMongoConfigReader implements IConfigReader {
     const { EXTERNAL_DATABASE_ID, ALLOWED_METASITES, URI }: {EXTERNAL_DATABASE_ID: string, ALLOWED_METASITES: string, URI: string} = { ...process.env, ...externalConfig }
     const config = { EXTERNAL_DATABASE_ID, ALLOWED_METASITES, URI }
 
-    return { config, secretMangerError: secretMangerError }
+    return { config, secretMangerError }
   }
 
   async readConfig() {

diff --git a/libs/external-db-dynamodb/src/sql_filter_transformer.spec.ts b/libs/external-db-dynamodb/src/sql_filter_transformer.spec.ts
@@ -154,7 +154,7 @@ describe('Sql Parser', () => {
                 const filter = {
                     operator: eq,
                     fieldName: ctx.fieldName,
-                    value: value
+                    value
                 }
 
                 expect( env.filterParser.parseFilter(filter) ).toEqual([{

diff --git a/libs/external-db-dynamodb/tests/e2e-testkit/dynamodb_resources.ts b/libs/external-db-dynamodb/tests/e2e-testkit/dynamodb_resources.ts
@@ -6,7 +6,7 @@ export * as capabilities from '../../src/dynamo_capabilities'
 export const connection = async() => {
     const { connection, schemaProvider, cleanup } = init(connectionConfig(), accessOptions())
 
-    return { pool: connection, schemaProvider, cleanup: cleanup }
+    return { pool: connection, schemaProvider, cleanup }
 }
 
 export const cleanup = async() => {

diff --git a/libs/external-db-firestore/src/connection_provider.ts b/libs/external-db-firestore/src/connection_provider.ts
@@ -8,7 +8,7 @@ import { DbProviders } from '@wix-velo/velo-external-db-types'
 
 export default ({ projectId }: firestoreConfig): DbProviders<Firestore>  => {
     const firestore = new Firestore({
-        projectId: projectId,
+        projectId,
     })
 
     const databaseOperations = new DatabaseOperations(firestore)

diff --git a/libs/external-db-firestore/src/sql_filter_transformer.spec.ts b/libs/external-db-firestore/src/sql_filter_transformer.spec.ts
@@ -154,7 +154,7 @@ describe('Fire Store Parser', () => {
                 const filter = {
                     operator: eq,
                     fieldName: ctx.fieldName,
-                    value: value
+                    value
                 }
 
                 expect( env.filterParser.parseFilter(filter) ).toEqual([{

diff --git a/libs/external-db-google-sheets/tests/e2e-testkit/google_sheets_resources.ts b/libs/external-db-google-sheets/tests/e2e-testkit/google_sheets_resources.ts
@@ -17,7 +17,7 @@ export const connection = async() => {
         apiPrivateKey: process.env['API_PRIVATE_KEY']
     }
     const { connection, schemaProvider, cleanup } = await init(googleSheetsConfig)
-    return { pool: connection, schemaProvider, cleanup: cleanup }
+    return { pool: connection, schemaProvider, cleanup }
 }   
 
 export const cleanup = async() => {
@@ -37,7 +37,7 @@ export const setActive = () => {
 
 export const enviormentVariables = {
     TYPE: 'google-sheet',
-    SHEET_ID: SHEET_ID
+    SHEET_ID
 }
 
 export const name = 'google-sheets'
diff --git a/libs/external-db-google-sheets/tests/google_sheet_doc_class.js b/libs/external-db-google-sheets/tests/google_sheet_doc_class.js
@@ -5,7 +5,7 @@ class GoogleSpreadsheetDoc {
     constructor(spreadsheetId, title) {
         this.spreadsheetId = spreadsheetId
         this.properties = {
-            title: title,
+            title,
         }
         this.sheets = []
         this.namedRanges = []

diff --git a/libs/external-db-google-sheets/tests/templates.js b/libs/external-db-google-sheets/tests/templates.js
@@ -11,7 +11,7 @@ const batchGetValuesResponse = (spreadsheetId, sheet, range, majorDimension, val
       {
         range: `${sheet}!${range}`,
         majorDimension: `${majorDimension}`,
-        values: values
+        values
       }
     ]
 })
@@ -21,7 +21,7 @@ const spreadsheet = (spreadsheetId, title, sheets = []) => ({
     properties: {
       title: `${title}`
     },
-    sheets: sheets
+    sheets
 })
 
 const updateValuesResponse = (spreadsheetId, sheet, range, updatedRows, updatedColumns, updatedCells) => ({

diff --git a/libs/external-db-mongo/src/sql_filter_transformer.spec.ts b/libs/external-db-mongo/src/sql_filter_transformer.spec.ts
@@ -141,7 +141,7 @@ describe('Sql Parser', () => {
                 const filter = {
                     operator: eq,
                     fieldName: ctx.fieldName,
-                    value: value
+                    value
                 }
 
                 expect(env.filterParser.parseFilter(filter)).toEqual([{

diff --git a/libs/external-db-mongo/tests/drivers/sql_filter_transformer_test_support.ts b/libs/external-db-mongo/tests/drivers/sql_filter_transformer_test_support.ts
@@ -51,7 +51,7 @@ export const givenAggregateQueryWith = (having: any, numericColumns: any[], colu
                                             [columnAliases[0]]: { $max: `$${c[0]}` },
                                             [columnAliases[1]]: { $sum: `$${c[1]}` }
                                         } }, 
-                                        groupByColumns: groupByColumns,
+                                        groupByColumns,
                                         havingFilter: { $match: {} },
                                        })
 }

diff --git a/libs/external-db-mongo/tests/e2e-testkit/mongo_resources.ts b/libs/external-db-mongo/tests/e2e-testkit/mongo_resources.ts
@@ -7,7 +7,7 @@ export * as capabilities from '../../src/mongo_capabilities'
 export const connection = async() => {
     const { connection, schemaProvider, cleanup } = await init({ connectionUri: 'mongodb://root:pass@localhost/testdb' })
 
-    return { pool: connection, schemaProvider, cleanup: cleanup }
+    return { pool: connection, schemaProvider, cleanup }
 }
 
 export const cleanup = async() => {

diff --git a/libs/external-db-mssql/src/sql_filter_transformer.spec.ts b/libs/external-db-mssql/src/sql_filter_transformer.spec.ts
@@ -178,7 +178,7 @@ describe('Sql Parser', () => {
                 const filter = {
                     operator: eq as AdapterOperator,
                     fieldName: ctx.fieldName,
-                    value: value
+                    value
                 }
 
                 expect( env.filterParser.parseFilter(filter) ).toEqual([{

diff --git a/libs/external-db-mssql/src/sql_filter_transformer.ts b/libs/external-db-mssql/src/sql_filter_transformer.ts
@@ -63,7 +63,7 @@ export default class FilterParser {
             fieldsStatement: filterColumnsStr.join(', '),
             groupByColumns,
             havingFilter: filterExpr,
-            parameters: parameters,
+            parameters,
         }
     }
 
@@ -81,8 +81,7 @@ export default class FilterParser {
     }
 
     extractFilterExprAndParams(havingFilter: { filterExpr: any; parameters: any }[]) {
-        return havingFilter.map(({ filterExpr, parameters }) => ({ filterExpr: filterExpr !== '' ? `HAVING ${filterExpr}` : '',
-                                                              parameters: parameters }))
+        return havingFilter.map(({ filterExpr, parameters }) => ({ filterExpr: filterExpr !== '' ? `HAVING ${filterExpr}` : '', parameters }))
                         .concat({ filterExpr: '', parameters: {} })[0]
     }
 

diff --git a/libs/external-db-mssql/tests/drivers/sql_filter_transformer_test_support.ts b/libs/external-db-mssql/tests/drivers/sql_filter_transformer_test_support.ts
@@ -41,7 +41,7 @@ export const givenAggregateQueryWith = (having: any, numericColumns: any[], colu
     when(filterParser.parseAggregation).calledWith({ postFilteringStep: filter, processingStep: having })
                                        .mockReturnValue({
                                            fieldsStatement: `${groupByColumns.map( escapeId )}, MAX(${escapeId(c[0])}) AS ${escapeId(columnAliases[0])}, SUM(${escapeId(c[1])}) AS ${escapeId(columnAliases[1])}`,
-                                           groupByColumns: groupByColumns,
+                                           groupByColumns,
                                            havingFilter: '',
                                            parameters: {},
                                        })

diff --git a/libs/external-db-mssql/tests/e2e-testkit/mssql_resources.ts b/libs/external-db-mssql/tests/e2e-testkit/mssql_resources.ts
@@ -23,7 +23,7 @@ const extraOptions = {
 export const connection = async() => {
     const { connection, schemaProvider, cleanup } = await init(testEnvConfig, extraOptions)
 
-    return { pool: connection, schemaProvider, cleanup: cleanup }
+    return { pool: connection, schemaProvider, cleanup }
 }
 
 export const cleanup = async() => {

diff --git a/libs/external-db-mysql/src/sql_filter_transformer.spec.ts b/libs/external-db-mysql/src/sql_filter_transformer.spec.ts
@@ -165,7 +165,7 @@ describe('Sql Parser', () => {
                 const filter = {
                     operator: eq,
                     fieldName: ctx.fieldName,
-                    value: value
+                    value
                 }
 
                 expect( env.filterParser.parseFilter(filter) ).toEqual([{

diff --git a/libs/external-db-mysql/src/sql_filter_transformer.ts b/libs/external-db-mysql/src/sql_filter_transformer.ts
@@ -213,7 +213,7 @@ export default class FilterParser implements IMySqlFilterParser {
             fieldsStatement: filterColumnsStr.join(', '),
             groupByColumns,
             havingFilter: filterExpr,
-            parameters: parameters,
+            parameters,
         }
     }
 
@@ -225,8 +225,7 @@ export default class FilterParser implements IMySqlFilterParser {
     }
 
     extractFilterExprAndParams(havingFilter: { filterExpr: any; parameters: any }[]) {
-        return havingFilter.map(({ filterExpr, parameters }) => ({ filterExpr: filterExpr !== '' ? `HAVING ${filterExpr}` : '',
-                                                                     parameters: parameters }))
+        return havingFilter.map(({ filterExpr, parameters }) => ({ filterExpr: filterExpr !== '' ? `HAVING ${filterExpr}` : '', parameters }))
                            .concat(EmptyFilter)[0]
     }
 

diff --git a/libs/external-db-mysql/tests/drivers/sql_filter_transformer_test_support.ts b/libs/external-db-mysql/tests/drivers/sql_filter_transformer_test_support.ts
@@ -41,7 +41,7 @@ export const givenAggregateQueryWith = (having: any, numericColumns: any[], colu
     when(filterParser.parseAggregation).calledWith({ postFilteringStep: filter, processingStep: having })
                                        .mockReturnValue({
                                            fieldsStatement: `${groupByColumns.map( escapeId )}, MAX(${escapeId(c[0])}) AS ${escapeId(columnAliases[0])}, SUM(${escapeId(c[1])}) AS ${escapeId(columnAliases[1])}`,
-                                           groupByColumns: groupByColumns,
+                                           groupByColumns,
                                            havingFilter: '',
                                            parameters: [],
                                        })

diff --git a/libs/external-db-mysql/tests/e2e-testkit/mysql_resources.ts b/libs/external-db-mysql/tests/e2e-testkit/mysql_resources.ts
@@ -7,7 +7,7 @@ export * as capabilities from '../../src/mysql_capabilities'
 
 export const connection = () => {
     const { connection, schemaProvider, cleanup } = init({ host: 'localhost', user: 'test-user', password: 'password', db: 'test-db' }, { connectionLimit: 1, queueLimit: 0 })
-    return { pool: connection, schemaProvider, cleanup: cleanup }
+    return { pool: connection, schemaProvider, cleanup }
 }
 
 export const cleanup = async() => {

diff --git a/libs/external-db-postgres/src/connection_provider.ts b/libs/external-db-postgres/src/connection_provider.ts
@@ -33,8 +33,8 @@ export default (cfg: PostgresConfig, _poolOptions: postgresPoolOptions) => {
     const schemaProvider = new SchemaProvider(pool)
 
     return { 
-        dataProvider: dataProvider,
-        schemaProvider: schemaProvider,
+        dataProvider,
+        schemaProvider,
         databaseOperations, 
         connection: pool, 
         cleanup: async() => pool.end(() => {}) 

diff --git a/libs/external-db-postgres/src/postgres_schema_provider.ts b/libs/external-db-postgres/src/postgres_schema_provider.ts
@@ -99,7 +99,7 @@ export default class SchemaProvider implements ISchemaProvider {
         const fields = res.rows.map(r => ({ field: r.field, type: r.type })).map(r => this.appendAdditionalRowDetails(r))
         return  {
             id: collectionName,
-            fields: fields,
+            fields,
             capabilities: this.collectionCapabilities(res.rows.map(r => r.field))
         }
     }

diff --git a/libs/external-db-postgres/src/sql_filter_transformer.spec.ts b/libs/external-db-postgres/src/sql_filter_transformer.spec.ts
@@ -177,7 +177,7 @@ describe('Sql Parser', () => {
                 const filter = {
                     operator: eq,
                     fieldName: ctx.fieldName,
-                    value: value
+                    value
                 }
 
                 expect( env.filterParser.parseFilter(filter, ctx.offset) ).toEqual([{

diff --git a/libs/external-db-postgres/src/sql_filter_transformer.ts b/libs/external-db-postgres/src/sql_filter_transformer.ts
@@ -62,7 +62,7 @@ export default class FilterParser {
             fieldsStatement: filterColumnsStr.join(', '),
             groupByColumns,
             havingFilter: filterExpr,
-            parameters: parameters,
+            parameters,
             offset: offsetAfterAggregation
         }
     }
@@ -80,8 +80,7 @@ export default class FilterParser {
     }
 
     extractFilterExprAndParams(havingFilter: any[], offset: number) {
-        return havingFilter.map(({ filterExpr, parameters, offset }) => ({ filterExpr: filterExpr !== '' ? `HAVING ${filterExpr}` : '',
-                                                                     parameters: parameters, offset }))
+        return havingFilter.map(({ filterExpr, parameters, offset }) => ({ filterExpr: filterExpr !== '' ? `HAVING ${filterExpr}` : '', parameters, offset }))
                            .concat({ ...EmptyFilter, offset: offset ?? 1 })[0]
     }
 
@@ -102,7 +101,7 @@ export default class FilterParser {
                         filter: [ ...o.filter, ...res],
                         offset: res.length === 1 ? res[0].offset : o.offset
                     }
-                }, { filter: [], offset: offset })
+                }, { filter: [], offset })
 
                 const op = operator === and ? ' AND ' : ' OR '
                 return [{
@@ -209,7 +208,7 @@ export default class FilterParser {
         } else if ((operator === eq || operator === ne) && isNull(value)) {
             return {
                 sql: '',
-                offset: offset
+                offset
             }
         }
 

diff --git a/libs/external-db-postgres/tests/drivers/db_operations_test_support.ts b/libs/external-db-postgres/tests/drivers/db_operations_test_support.ts
@@ -21,7 +21,7 @@ const dbOperationWithMisconfiguredHost = () => new DatabaseOperations(createPool
 export const dbOperationWithValidDB = () => {
     const { connection, cleanup } = createPool({ } )
     const dbOperations = new DatabaseOperations(connection)
-    return { dbOperations, cleanup: cleanup }
+    return { dbOperations, cleanup }
 }
 
 export const misconfiguredDbOperationOptions = () => ([   ['pool connection with wrong password', () => dbOperationWithMisconfiguredPassword()],

diff --git a/libs/external-db-postgres/tests/drivers/sql_filter_transformer_test_support.ts b/libs/external-db-postgres/tests/drivers/sql_filter_transformer_test_support.ts
@@ -40,7 +40,7 @@ export const givenAggregateQueryWith = (having: any, numericColumns: { name: str
     when(filterParser.parseAggregation).calledWith({ postFilteringStep: filter, processingStep: having }, offest)
                                        .mockReturnValue({
                                            fieldsStatement: `${groupByColumns.map( escapeIdentifier ).join(', ')}, MAX(${escapeIdentifier(numericColumns[0].name)}) AS ${escapeIdentifier(columnAliases[0])}, SUM(${escapeIdentifier(numericColumns[1].name)}) AS ${escapeIdentifier(columnAliases[1])}`,
-                                           groupByColumns: groupByColumns,
+                                           groupByColumns,
                                            offset: offest,
                                            havingFilter: '',
                                            parameters: [],