-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation to v3 #394
Draft
Idokah
wants to merge
21
commits into
managed-adapter
Choose a base branch
from
postgres-to-v3
base: managed-adapter
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implementation to v3 #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* lint fixes * enable husky
* refactor app_data_e2e * .
* filter by date v3 * remove ts-ignore
* implementing errors spi * wip * added some tests * wip * changed 400 to 500 * applied pr commesnts * wip * use data test support * fix duplicate item insert test * lint Co-authored-by: Ido Kahlon <idokk96@gmail.com>
* feat: new collection related types * refactor: collection spi update * feat: list all collection in the new format * feat: getColumnCapabilitiesFor implementation in MySql * feat: new type and interface methods * feat: new collection implementations * feat: changeColumn mysql implementation * feat: new collection routes * feat: some of the functions of the class will be optional * feat: stream collection api * test: expect to the right things * feat: give subtype to field type * test: new collection e2e tests * feat: clear cache when refreshing * tests: delete collection test * feat: new column compare function and tests * test: extract some function in class * refactor: rename function in schema utils * style: some lint fixes * style: some lint fixes * style: some lint fixes * refactor: extracted function from schema provider * test: new tests for schema utils * test: remove unsupported field types from gen * refactor: deleted old schema routes * test: disable schema hooks test * test: disabled test * test: refactor some tests * refactor: delete old schema functions * refactor: extract some internal logic to function * refactor: removed schemas tests * refactor: schema import names * test: schema hooks tests rename and skip * refactor: lint fixes + extract collection types to a new file * lint fixes after rebase * test: new collection update test - change type * fix: added collection name to catch in change type * Change float default precision (#380) * new number column - float ,mysql float- percision (15,2) * fix unit tests * test: moved some tests Co-authored-by: Ido Kahlon <idokk96@gmail.com> Co-authored-by: Ido Kahlon <82806105+Idokah@users.noreply.github.com>
* feat: capabilities property in collection object * refactor: some refactors * refactor: refactors based on review * refactor: some refactors based on reviews * refactor: rename some variables and methods
Idokah
force-pushed
the
managed-adapter
branch
3 times, most recently
from
February 7, 2023 14:49
afd93fc
to
6f0ce45
Compare
Idokah
force-pushed
the
managed-adapter
branch
from
October 2, 2023 07:49
2543146
to
07f9081
Compare
MXPOL
force-pushed
the
managed-adapter
branch
from
October 31, 2023 15:17
6977336
to
83d0af1
Compare
Idokah
force-pushed
the
managed-adapter
branch
from
November 22, 2023 10:50
49a50a1
to
0abfc0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apps:
createApp
withcreateAppWithWixDataBaseUrl
<impl>.testResources.supportedOperations
with<impl>.testResources
Current implementation changes:
Schema:
Data:
Error handling:
collectionName
with each error code (sql_exception_translator).e2e:
general: