First delivery #3

Cicero-Henrique · 2024-10-09T09:14:37Z

In this delivery, I made just the basic tests;
The tests are in a directory named tests;

First delivery tests

wlsf82

@Cicero-Henrique, parabéns pela primeira implementação. 👏🏻

Deixei comentários ao longo do seu código, os quais creio que lhe ajudarão a melhorar o design do mesmo.

Aguarde até o próximo encontro antes de implementar as mudanças.

.gitignore

README.md

backend/package-lock.json

tests/cypress/support/commandsGui.js

tests/cypress/support/e2e.js

tests/package-lock.json

tests/package.json

…click

…mers

Cicero-Henrique · 2024-10-27T23:23:19Z

In this delivery:

Fixed the previous tests;
Add the advanced tests;
Add the ESLint to the project;

wlsf82

Ótimo trabalho @Cicero-Henrique! 👏🏻

Deixei alguns comentários finais, os quais creio que lhe ajudarão a melhorar ainda mais o design dos seus testes.

Espero que tenha gostado na Test Design Masterclass.

wlsf82 · 2024-10-29T18:19:57Z

.github/workflows/actionTests.yaml

+        env:
+          CI: true
+
+      - name: Install and run tests


Que tal criar uma estratégia para execução de diferentes testes em paralelo uns aos outros.

Exemplo, enquanto roda os testes de API em uma máquina, os teste de GUI poderiam estar rodando em outro, fornecendo feedback mais rápido.

wlsf82 · 2024-10-29T18:20:09Z

.github/workflows/actionTests.yaml

+          npm test
+        continue-on-error: true # Action should continue in failure situations
+
+      - name: Upload Cypress screenshots


wlsf82 · 2024-10-29T18:22:39Z

cypress/e2e/api/testsApi.cy.js

@@ -0,0 +1,135 @@
+describe('Validate the API requests', () => {


Que tal uma descrição melhor para a suíte de testes?

Algo como EngageShere - GET customers endpoint.

A propósito, recomendo pensar num melhor nome para o arquivo também.

Eu nomeria simplemente EngageSphere.cy.js, e visto que ele já está na pasta cypress/e2e/api/, é óbvio que são testes de API, e portanto, isso pode ser omitido do nome do arquivo.

wlsf82 · 2024-10-29T18:23:09Z

cypress/e2e/api/testsApi.cy.js

+        method: 'GET',
+        url: CUSTOMERS_API_URL,
+      }).then(({ status }) => {
+        expect(status).to.equal(200);


Que tal verificar também o que é retornado no body da resposta?

wlsf82 · 2024-10-29T18:23:54Z

cypress/e2e/api/testsApi.cy.js

+        method: 'GET',
+        url: `${CUSTOMERS_API_URL}?page=2`,
+      }).then(({ status }) => {
+        expect(status).to.equal(200);


Essa verificação só garante o sucesso da requisição, no entanto, não garante que os customers da página 2 foram retornados.

wlsf82 · 2024-10-29T18:57:14Z

cypress/e2e/gui/testsGui.cy.js

+      cy.get('[data-testid="size-filter"]').select('Medium');
+      cy.get('[data-testid="industry-filter"]').select('Retail');
+      cy.wait('@getCustomers');
+      cy.get('[aria-label="View company: Littel Co"]').click();


Que tal algo mais simples, como o seguinte?

Suggested change

cy.get('[aria-label="View company: Littel Co"]').click();

cy.contains('button', 'View').click();

wlsf82 · 2024-10-29T18:58:27Z

cypress/e2e/gui/testsGui.cy.js

+      cy.contains('Hide address').click();
+      cy.contains('Show address').should('be.visible');
+    });
+    it('Apply a filter, go to a customer page, return to the list page, and check if the previous filters are selected', () => {


Que tal uma descrição mais curta, como a seguinte?

keeps the filters when coming back from the customer details view

wlsf82 · 2024-10-29T18:59:58Z

cypress/e2e/gui/testsGui.cy.js

+    context('Validate the messenger', () => {
+      it('Open and close the messenger', () => {
+        cy.get('[aria-label="Open messenger"]').should('be.visible').click();
+        cy.get('[aria-label="Close messenger"]').should('be.visible').click();


Que tal verificar que o form é exibido antes de fechá-lo?

Pois esse teste só verifica o botão, mais nada.

wlsf82 · 2024-10-29T19:01:01Z

cypress/e2e/gui/testsGui.cy.js

+        cy.get('[aria-label="Close messenger"]').click();
+        cy.get('[aria-label="Open messenger"]').should('be.visible').click();
+
+        // Check if the form is empty


Suggested change

// Check if the form is empty

// Check if the form fields are empty

Se for usar um comentário, torne-o o mais descritivo possível.

wlsf82 · 2024-10-29T19:03:16Z

cypress/support/e2e.js

@@ -0,0 +1 @@
+import 'cypress-axe';


Suggested change

import 'cypress-axe';

import 'cypress-axe';

Recomenda-se deixar uma linha em branco ao final de cada arquivo para que ferramentas como o GitHub não exibam o ícone de No newline at end of file.

Isso é uma boa prática e convenção a ser seguida.

Cicero-Henrique and others added 7 commits October 7, 2024 21:33

First commit

8985e99

Add spaces

09dc498

Improve tests

9adb68d

Add comments

c502d4b

Add a backend validation

97f9384

Update readme

d018fbe

Merge pull request #1 from Cicero-Henrique/tests

dd84610

First delivery tests

wlsf82 requested changes Oct 9, 2024

View reviewed changes

Cicero-Henrique added 22 commits October 12, 2024 23:56

Reverting all packages and package-locks committed by mistake.

55a5b77

Moving the tests to root of the project and adding scripts

b2e73cc

Update the readme

71d3608

Add end line

cb296d9

Change urls to enviroment variables

27ba9d4

Improve the command name

37f546f

Insert the cookies in the browser

a7ba04e

Fix the select filter test case

e293670

Improve the test that returns to the clients list

7d38b70

Improve the test that checks the footer

62eacb5

Separating the assertions

3e521a1

Remove dynamic parts from cy.get

bfec7a9

Reduce the code to check the header

fab1a00

Reduce the code to open and close the messenger

5a560de

Remove the custom command, reduce the tick time and reduce a line to …

324d88c

…click

Reduce a line to click on the element

f3ee193

Remove the getCustomers custom command

90fda63

Fix the first test, removing unnecessary API validation

1ae5985

Add pagination validation

bedbdeb

Validating the limits of items per page

4de4752

Validate the filter by company size

a0d9f88

Validate the industry filter

fee41b8

Cicero-Henrique added 21 commits October 25, 2024 17:30

Add test to check the customer address

1a95dc8

Change customer fixture and fix the tests

4925d88

Add missing info tests

a1a818d

Add test to hide address

44dd92b

Change from many describes to only one

465f1c2

Add theme tests

eeeb75c

Add the first pagination test

2a83a7d

Add first test for two page scenarios

741a654

Add second test for two pages validation

a7d4f60

Add one page test

69642f3

Add test to check if the pagination element is rendered with 50 custo…

5426c7f

…mers

Add test to sort ascendant

9817d4d

Add test to sort descendant

cad1b0f

Increase the width

19d9aca

Add test to sort by number of employees descendant

9a557ad

Add test to validate the sort by number of employees ascendant

bdb364d

Add test to download csv

00fbbc8

Fix csv test

c51ca1a

Add eslint

ff4f7ed

Fix the delay scenario

dfe2715

Remove blank lines

645e16d

Cicero-Henrique requested review from wlsf82 and jonathanrsbr October 27, 2024 23:23

Cicero-Henrique added 5 commits October 29, 2024 05:42

Add first acessibility test

1cf0867

Add test to check accessibility on customers list dark mode

b031a27

Add test to check accessibility on customers details light mode

86a1136

check accessibility on dark mode in details page

3636f16

Add test of messenget button

cd52917

wlsf82 requested changes Oct 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First delivery #3

First delivery #3

Cicero-Henrique commented Oct 9, 2024

wlsf82 left a comment

Cicero-Henrique commented Oct 27, 2024

wlsf82 left a comment

wlsf82 Oct 29, 2024

wlsf82 Oct 29, 2024

wlsf82 Oct 29, 2024

wlsf82 Oct 29, 2024

wlsf82 Oct 29, 2024

wlsf82 Oct 29, 2024

wlsf82 Oct 29, 2024

wlsf82 Oct 29, 2024

wlsf82 Oct 29, 2024

wlsf82 Oct 29, 2024

wlsf82 Oct 29, 2024

		@@ -0,0 +1,135 @@
		describe('Validate the API requests', () => {

	cy.get('[aria-label="View company: Littel Co"]').click();
	cy.contains('button', 'View').click();

	// Check if the form is empty
	// Check if the form fields are empty

First delivery #3

Are you sure you want to change the base?

First delivery #3

Conversation

Cicero-Henrique commented Oct 9, 2024

wlsf82 left a comment

Choose a reason for hiding this comment

Cicero-Henrique commented Oct 27, 2024

wlsf82 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment