Update Vite-related packages #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, this doesn’t seem to affect the compatibility of the generated code: while the output changes a bit, its size is almost identical; furthermore, the Vite changelog mentions that the nullish coalescing operator isn’t transpiled anymore since Vite 4, but we use such an operator in actions.ts and the corresponding build code can be found by searching for .language.display.label, and it doesn’t appear to have changed at all – so I think our build config is sufficiently specific that the change to Vite’s defaults doesn’t actually change the target version. Bug: T348108
micgro42
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, this doesn’t seem to affect the compatibility of the generated code: while the output changes a bit, its size is almost identical; furthermore, the Vite changelog mentions that the nullish coalescing operator isn’t transpiled anymore since Vite 4, but we use such an operator in
actions.tsand the corresponding build code can be found by searching for.language.display.label, and it doesn’t appear to have changed at all – so I think our build config is sufficiently specific that the change to Vite’s defaults doesn’t actually change the target version.Bug: T348108