Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevLangCodeRetriever: Adjust property-id used for language code #546

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

micgro42
Copy link
Collaborator

This was changed in production to user the broader coverage provided by IETF code, see T348923.

Bug: T348923

This was changed in production to user the broader coverage provided by IETF code, see T348923.

Bug: T348923
@lucaswerkmeister
Copy link
Member

Hm, this doesn’t seem to be working properly for me:
image
It’s making the right API request, and the API returns en-GB, yet it neither accepts the language code nor complains that it’s invalid. It’s acting as if there was no statement… any idea why?

@lucaswerkmeister
Copy link
Member

Aha, I’m pretty sure return processWbGetClaimsResponse( response, 'P218' ); also needs to use the new property ID :)

@lucaswerkmeister
Copy link
Member

Yeah, with that it seems to be working (“This Item has an unrecognized language code. Please select one below.”).

@micgro42
Copy link
Collaborator Author

Grr, why do we have that literal string in two places!?

/me looks at blame for that file.

Ah, of course! I did!

image

@micgro42
Copy link
Collaborator Author

micgro42 commented Oct 23, 2023

ok, with that cypress fixup it should be fine now 🤞

Copy link
Member

@lucaswerkmeister lucaswerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(MwApiLangCodeRetriever.test.ts also uses P218 in some test data, but I think that’s fully unrelated and can be updated separately.)

@micgro42 micgro42 merged commit a02b386 into main Oct 23, 2023
2 checks passed
@micgro42 micgro42 deleted the chore/devLanguageCode branch October 23, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants