-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevLangCodeRetriever: Adjust property-id used for language code #546
Conversation
Aha, I’m pretty sure |
Yeah, with that it seems to be working (“This Item has an unrecognized language code. Please select one below.”). |
ok, with that cypress fixup it should be fine now 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(MwApiLangCodeRetriever.test.ts
also uses P218 in some test data, but I think that’s fully unrelated and can be updated separately.)
This was changed in production to user the broader coverage provided by IETF code, see T348923.
Bug: T348923