From 96427e94cb2c831003ecb0bddabcd9232deb900f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Gro=C3=9Fe?= Date: Mon, 23 Oct 2023 15:57:03 +0200 Subject: [PATCH 1/3] DevLangCodeRetriever: Adjust property-id used for language code This was changed in production to user the broader coverage provided by IETF code, see T348923. Bug: T348923 --- src/data-access/DevLangCodeRetriever.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/data-access/DevLangCodeRetriever.ts b/src/data-access/DevLangCodeRetriever.ts index 6c68e2e8..07d4d79a 100644 --- a/src/data-access/DevLangCodeRetriever.ts +++ b/src/data-access/DevLangCodeRetriever.ts @@ -6,7 +6,7 @@ export default class DevLangCodeRetriever implements LangCodeRetriever { const response = await fetch( 'https://www.wikidata.org/w/api.php?' + new URLSearchParams( { action: 'wbgetclaims', entity: itemId, - property: 'P218', + property: 'P305', props: '', format: 'json', origin: '*', From 46293364d4cce604505dbfc9e188b382ed5c4f94 Mon Sep 17 00:00:00 2001 From: Lucas Werkmeister Date: Mon, 23 Oct 2023 16:06:34 +0200 Subject: [PATCH 2/3] fixup! DevLangCodeRetriever: Adjust property-id used for language code --- src/data-access/DevLangCodeRetriever.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/data-access/DevLangCodeRetriever.ts b/src/data-access/DevLangCodeRetriever.ts index 07d4d79a..ad1cf0a1 100644 --- a/src/data-access/DevLangCodeRetriever.ts +++ b/src/data-access/DevLangCodeRetriever.ts @@ -12,6 +12,6 @@ export default class DevLangCodeRetriever implements LangCodeRetriever { origin: '*', } ) ).then( ( r ) => r.json() ) as WbGetClaimsResponse; - return processWbGetClaimsResponse( response, 'P218' ); + return processWbGetClaimsResponse( response, 'P305' ); } } From 18c5462da05cea33d0ff44a212987256f1457146 Mon Sep 17 00:00:00 2001 From: Lucas Werkmeister Date: Mon, 23 Oct 2023 16:10:37 +0200 Subject: [PATCH 3/3] Update Cypress test for changed property ID --- cypress/e2e/NewLexemeForm.cy.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cypress/e2e/NewLexemeForm.cy.js b/cypress/e2e/NewLexemeForm.cy.js index 484b9330..aa456fb6 100644 --- a/cypress/e2e/NewLexemeForm.cy.js +++ b/cypress/e2e/NewLexemeForm.cy.js @@ -40,10 +40,10 @@ describe( 'NewLexemeForm', () => { cy.intercept( { query: { action: 'wbgetclaims' } }, { claims: { - P218: [ { + P305: [ { mainsnak: { snaktype: 'value', - property: 'P218', + property: 'P305', hash: 'faa942355921695b9fa30805f0bb66bc7ed5a433', datavalue: { value: 'en-gb',