Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Vue from v3.2.27 to v3.3.9 #579

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Upgrade Vue from v3.2.27 to v3.3.9 #579

merged 2 commits into from
Nov 30, 2023

Conversation

micgro42
Copy link
Collaborator

This follows the upgrade of the Vue version shipped with MediaWiki in I0b3b6adf (commit ed6f7b2). The goal is to have those two versions always exactly in sync.

Created with:
npm install vue@3.3.9 --save-exact

Bug: T352388

@micgro42
Upgrade Vue from v3.2.27 to v3.3.9
c60faf6 
This follows the upgrade of the Vue version shipped with MediaWiki in
I0b3b6adf (commit ed6f7b2). The goal is to have those two versions
always exactly in sync.

Created with:
`npm install vue@3.3.9 --save-exact`

Bug: T352388
@github-actions GitHub Actions
Copy link

https://74dd01c46e43aa2ab672755f73831a93da64--new-lexeme-special-page.netlify.app

@micgro42
Copy link
Collaborator Author

I'm tempted to just add as any to tests/unit/components/ItemLookup.test.ts to make the type check on the test pass for now, but I'm curious if anyone has a more type-safe idea right away.

I think I would want to prioritize getting this merged and deployed quickly over finding the necessarily best solution for this. We can still do so afterward. (I think this vue upgrade might also unlock updating the TypeScript version?)

@lucaswerkmeister
Copy link
Member

I'm tempted to just add as any to tests/unit/components/ItemLookup.test.ts to make the type check on the test pass for now, but I'm curious if anyone has a more type-safe idea right away.

I played with it locally, but couldn’t find anything that worked. Let’s just do the as any then, IMHO.

I think I would want to prioritize getting this merged and deployed quickly over finding the necessarily best solution for this. We can still do so afterward. (I think this vue upgrade might also unlock updating the TypeScript version?)

+1

@lucaswerkmeister
Suppress type error in tests
1d273db 
I tried to fix this by specifying the type of propsOverrides a bit
better (loosely similar to 710f3fe / #535), but didn’t end up with
anything that worked. Let’s just suppress the type error to unblock the
Vue upgrade.
@micgro42 micgro42 merged commit ed0ad3e into main Nov 30, 2023
2 checks passed
@micgro42 micgro42 deleted the chore/updateVue branch November 30, 2023 12:34
@lucaswerkmeister
Copy link
Member

(I think this vue upgrade might also unlock updating the TypeScript version?)

Opened #581 to remove the corresponding section from the README. (I haven’t actually tried upgrading TypeScript; I think it can wait until the next round of chores.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaswerkmeister lucaswerkmeister lucaswerkmeister approved these changes

@mariushoch mariushoch Awaiting requested review from mariushoch

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micgro42 @lucaswerkmeister