Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semver to resolve npm audit warning #731

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

codders
Copy link
Contributor

@codders codders commented Aug 12, 2024

Resolve REDoS issue with Semver, which is included as a dependency of libraries we are using.

GHSA-c2qf-rxjj-qqgw

Bug: T370126

 - @rushstack/eslint-patch: 1.10.2->1.10.4
   - Add eslint v9 support
 - @typescript-eslint/{eslint-plugin,parser}: 7.8.0 -> 7.18.0
   - Minor fixes, rule updates
 - @wmde/eslint-config-wikimedia-typescript: 0.2.9 -> 0.2.12
   - Bump dependencies for compatibility
 - eslint-config-wikimedia: 0.27.0 -> 0.28.2
   - Deprecate node < v16
   - Dependency updates
 - eslint-plugin-vuejs-accessibility: 2.3.0 -> 2.4.1
   - Rule updates, dependency updates

Bug: T370126
Upgrade vue since the version in `foreign-resources.yaml` has been
bumped, and upgrade vite-related includes to the latest:

 - vue, @vue/server-renderer 3.3.9 -> 3.4.27
   - bug fixes, performance improvements, Reactivity Transform
     has been removed, vue no longer registers JSX namespace
 - vue-tsc 2.0.16 -> 2.0.29
   - dependency updates, bugfixes
 - @vitejs/plugin-vue 5.0.4 -> 5.1.2
   - minor fixes and improvements, dependency updates
 - vite 5.2.11 -> 5.4.0
   - performance improvements, fixes, dependency updates

Bug: T370126
Upgrade stylelint and related dependencies to latest versions:
 - stylelint 15.11.0 -> 16.8.1
   - Removal of deprecated rules (including 'indentation')
   - Added support for ESM plugins
   - Deprecated CommonJS Node.js API
   - Changed CLI exit codes
   - Remove support for node < 18.12.0
 - stylelint-config-standard-scss 11.1.0 -> 13.1.0
   - Remove support for node < 18.12.0
   - Updated dependencies
 - stylelint-config-wikimedia 0.16.1 -> 0.17.2
   - Upgrade to stylelint 16
   - Dropped `text-decoration` rules

Bug: T370126
Update dependencies that don't belong with any other group:
 - axe-core 4.9.1 -> 4.10.0
   - new rule - summary elements, bug fixes
 - husky: 9.0.11 -> 9.1.4
   - some config deprecations, fixes
 - lint-staged 15.2.7 -> 15.2.8
   - Updated git version handling
 - start-server-and-test 2.0.3 -> 2.0.5
   - Update dependencies
 - ts-jest 29.1.2 -> 29.2.4
   - bug fixes, dependency updates
   - deprecation of `babel` and `createJestPreset`
 - typescript 5.4.5 -> 5.5.5
   - Disabled features deprecated in 5.0
   - stricter decorator parsing
   - `type undefined = any` is now illegal

Bug: T370126
Resolve REDoS issue with Semver, which is included as a dependency
of libraries we are using.

GHSA-c2qf-rxjj-qqgw

Bug: T370126
@codders codders requested a review from yerdua August 12, 2024 09:51
Copy link
Member

@lucaswerkmeister lucaswerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d be willing to bet quite a bit of money that there’s no possible way we’re affected by this vulnerability (when would we ever pass untrusted user input to semver?), but such are the joys of npm.

Base automatically changed from feat/update-dependencies-20240812 to main August 12, 2024 11:19
@codders codders dismissed lucaswerkmeister’s stale review August 12, 2024 11:19

The base branch was changed.

@codders codders merged commit 8396f13 into main Aug 13, 2024
2 checks passed
@codders codders deleted the bugfix/update-semver-20240812 branch August 13, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants