Use Codex Field + TextInput instead of Wikit TextInput #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the lemma to not use Wikit anymore. In Codex, this corresponds to two components, so use both. The spacing of the “required” asterisk is done differently – it’s no longer in a flex container, so establish the spacing using margin instead. The asterisk is now also part of the actual <label> element, which isn’t ideal but I think can’t be avoided within Codex. (Note that Codex doesn’t want us to indicate required fields at all; see also T374432.) Bug: T370054
Since Codex wants the status and messages as separate props, but we compute them at the same time, let’s have the computed return an object with both props. Bug: T370054
codders
reviewed
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the lemma to not use Wikit anymore. In Codex, this corresponds to two components, so use both.
The spacing of the “required” asterisk is done differently – it’s no longer in a flex container, so establish the spacing using margin instead. The asterisk is now also part of the actual element, which isn’t ideal but I think can’t be avoided within Codex. (Note that Codex doesn’t want us to indicate required fields at all; see also T374432.)
Bug: T370054
The second commit is optional, if you don’t like it I can take it out again:
Restructure error computation
Since Codex wants the status and messages as separate props, but we compute them at the same time, let’s have the computed return an object with both props.