Remove XOAUTH2 from Auto-Discovery SMTP auth feature #417
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed XOAUTH2 from the preferred SMTPAuthType list. Since XOAUTH2 requires a Bearer token the auto-discovery feature will not work, since it will expect user/password. Updated test cases to reflect these changes, ensuring proper alignment with the revised authentication preferences. This addresses #415
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 30 30
Lines 3532 3532
=======================================
Hits 3345 3345
Misses 138 138
Partials 49 49 ☔ View full report in Codecov by Sentry. |
wneessen
deleted the
bug/415_remove-xoauth-from-smtp-auth-auto-discovery
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed XOAUTH2 from the preferred SMTPAuthType list. Since XOAUTH2 requires a Bearer token the auto-discovery feature will not work, since it expects a user/password pair.
Updated test cases to reflect these changes, ensuring proper alignment with the revised authentication preferences.
This PR closes #415