-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a runtime-creation-sized Bloom Filter #5
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 71.42% 73.50% +2.07%
==========================================
Files 2 5 +3
Lines 35 117 +82
Branches 6 15 +9
==========================================
+ Hits 25 86 +61
- Misses 7 21 +14
- Partials 3 10 +7
|
Argh, why does the benchmark bot have to ping Brooke? 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good to me.
Not a major issue but would Box<[u8]>
better be represented as Bytes
here?
@appcypher Yeah, valid question. Generally I didn't need any functionality from |
Description
runtime_sized::BloomFilter
HashIndexIterator
(has no effect if the size is a power of two)Link to issue
Fixes #4
Type of change
Test plan (required)
Needs more tests. Consider this somewhat WIP.