Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch from SHA3-256 to BLAKE3-256 #32

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Jul 11, 2023

This switches the hashing algorithm from SHA3 to BLAKE3.
It also provides some additional helpful functions for key derivations.

@matheus23 matheus23 changed the title feat: Add Ratchet::key_derivation_data function feat: Switch from SHA3-256 to BLAKE3-256 Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #32 (31ee7c0) into main (7324499) will increase coverage by 4.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   12.32%   17.03%   +4.70%     
==========================================
  Files           8        8              
  Lines        1801     1849      +48     
  Branches      514      557      +43     
==========================================
+ Hits          222      315      +93     
+ Misses       1560     1500      -60     
- Partials       19       34      +15     
Impacted Files Coverage Δ
src/hash.rs 75.00% <100.00%> (+1.08%) ⬆️
src/ratchet.rs 93.63% <100.00%> (+1.00%) ⬆️

... and 3 files with indirect coverage changes

@matheus23 matheus23 self-assigned this Jul 17, 2023
Copy link
Member

@appcypher appcypher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@matheus23 matheus23 merged commit 30efdd6 into main Jul 18, 2023
5 checks passed
@matheus23 matheus23 deleted the matheus23/allow-other-hash-algs branch July 18, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants