Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get_raw_content_cid #385

Merged
merged 1 commit into from
Dec 18, 2023
Merged

feat: add get_raw_content_cid #385

merged 1 commit into from
Dec 18, 2023

Conversation

icidasset
Copy link
Member

Summary

Adds back the public content CID functionality that was previously removed, under the new name get_raw_content_cid. This method is async as opposed to its predecessor.

Test plan (required)

I've added a new test to wnfs-wasm/tests/public.spec.ts

After Merge

  • Does this change invalidate any docs or tutorials? If so ensure the changes needed are either made or recorded
  • Does this change require a release to be made? Is so please create and deploy the release

@icidasset icidasset requested a review from a team as a code owner December 18, 2023 11:49
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #385 (89650e9) into main (0964ac4) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   54.80%   54.85%   +0.05%     
==========================================
  Files          57       57              
  Lines        3936     3936              
  Branches      947      947              
==========================================
+ Hits         2157     2159       +2     
+ Misses       1169     1168       -1     
+ Partials      610      609       -1     
Files Coverage Δ
wnfs/src/public/file.rs 69.82% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Only thing to figure out would be CI, otherwise I approve :)

@matheus23 matheus23 merged commit db4295e into main Dec 18, 2023
10 checks passed
@matheus23 matheus23 deleted the get_raw_content_cid branch December 18, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants