Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing componentDidCatch #17

Open
simonguo opened this issue Aug 29, 2018 · 5 comments
Open

Missing componentDidCatch #17

simonguo opened this issue Aug 29, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@simonguo
Copy link

No description provided.

@dance2die
Copy link
Contributor

And also getDerivedStateFromError will be available in v 16.6.

@AndrewCraswell
Copy link

Both are available now, any chance of getting the diagram updated?

@wojtekmaj
Copy link
Owner

Both componentDidCatch and getDerivedStateFromError are kinda "on the side" of component lifecycle. Could be listed somewhere next to the chart, but I don't think they belong to any place on the actual chart.

@wojtekmaj wojtekmaj added the enhancement New feature or request label May 3, 2019
@hudidit
Copy link

hudidit commented May 9, 2019

@wojtekmaj Actually I think they does belong to 'less common lifecycles'. IMO one of the goals of this diagram is to help people understand the execution sequence of lifecycle methods. At some point, we would wonder when componentDidCatch and getDerivedStateFromError are executed.

@s-h-a-d-o-w
Copy link

At some point, we would wonder when componentDidCatch and getDerivedStateFromError are executed.

Hopefully, we wonder first, then implement. ;)
While Brian Vaughn has explained those methods in depth here, this diagram is great at illustrating what he describes and so I think it would be helpful to also have these two in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants