Replaced the function empty with a more strict comparison

wol-soft · Sep 19, 2024 · 5897825 · 5897825
1 parent da0bc3e
commit 5897825
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/Utils/NormalizedName.php b/src/Utils/NormalizedName.php
@@ -28,7 +28,7 @@ static function (string $element): string {
 
         $attributeName = join('', $elements);
 
-        if (empty($attributeName)) {
+        if ($attributeName === '') {
             throw new SchemaException(
                 sprintf(
                     "Name '%s' results in an empty name in file %s",

diff --git a/tests/Basic/BasicSchemaGenerationTest.php b/tests/Basic/BasicSchemaGenerationTest.php
@@ -275,7 +275,8 @@ public function testPropertyNamesAreNormalized(): void
             'space property' => '   ',
             'numeric42' => 13,
             '1000' => 1000,
-            '1000string' => '1000'
+            '1000string' => '1000',
+            '0' => 0,
         ]);
 
         $this->assertSame('___', $object->getUnderscoreProperty());
@@ -284,6 +285,7 @@ public function testPropertyNamesAreNormalized(): void
         $this->assertSame(13, $object->getNumeric42());
         $this->assertSame(1000, $object->get1000());
         $this->assertSame('1000', $object->get1000string());
+        $this->assertSame(0, $object->get0());
     }
 
     public function testEmptyNormalizedPropertyNameThrowsAnException(): void

diff --git a/tests/Schema/BasicSchemaGenerationTest/NameNormalization.json b/tests/Schema/BasicSchemaGenerationTest/NameNormalization.json
@@ -21,6 +21,9 @@
     },
     "1000string": {
       "type": "string"
+    },
+    "0": {
+      "type": "integer"
     }
   }
 }