Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for non required const-properties #82

Conversation

kolodkinvalentin
Copy link
Contributor

JSON schema allows us to declare a field as a constant, although that field may be optional and not present in the document, I made support for this feature

@coveralls
Copy link

coveralls commented Sep 16, 2024

Pull Request Test Coverage Report for Build 10938575664

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 98.851%

Totals Coverage Status
Change from base Build 10738436689: 0.003%
Covered Lines: 3012
Relevant Lines: 3047

💛 - Coveralls

tests/Objects/RequiredPropertyTest.php Outdated Show resolved Hide resolved
src/PropertyProcessor/Property/ConstProcessor.php Outdated Show resolved Hide resolved
@wol-soft wol-soft changed the base branch from master to optionalConst September 19, 2024 10:55
@wol-soft wol-soft merged commit 83acf61 into wol-soft:optionalConst Sep 19, 2024
5 checks passed
@wol-soft wol-soft mentioned this pull request Sep 19, 2024
@kolodkinvalentin kolodkinvalentin deleted the feat-required-and-optional-const-property branch September 20, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants