Skip to content

Commit

Permalink
Rework some shell code for supervisor and hwloc (#35579)
Browse files Browse the repository at this point in the history
This attempts to fix our ability to parse shell code with `melange` by
working around parsing bugs in https://github.com/mvdan/sh in a way that
hopefully doesn't actually change build logic.

We first noticed this problem while seeing wolfictl's CI failing on the
latest bump of melange:
https://github.com/wolfi-dev/wolfictl/actions/runs/12088082103/job/33710862119?pr=1345

Related to chainguard-dev/melange#1622

cc: @jonjohnsonjr @imjasonh

---------

Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
  • Loading branch information
luhring authored Dec 1, 2024
1 parent d4a7e8c commit 0ede777
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
6 changes: 4 additions & 2 deletions hwloc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ test:
hwloc-diff --help
hwloc-distrib --version
hwloc-distrib --help
if [[ uname -m == 'x86_64']]; then
if [[ "$(uname -m)" == 'x86_64' ]]
then
hwloc-gather-cpuid --version
hwloc-gather-cpuid --help
fi;
Expand All @@ -105,7 +106,8 @@ test:
lstopo --help
lstopo-no-graphics --version
lstopo-no-graphics --help
if [[ uname -m == 'x86_64']]; then
if [[ "$(uname -m)" == 'x86_64' ]]
then
hwloc-dump-hwdata --version
hwloc-dump-hwdata --help
fi
1 change: 1 addition & 0 deletions supervisor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ pipeline:
notifempty
nocompress
}
EOF
chmod 600 ${{targets.destdir}}/etc/supervisord.conf
chmod 644 ${{targets.destdir}}/etc/logrotate.d/supervisord
Expand Down

0 comments on commit 0ede777

Please sign in to comment.