Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference hashes #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crozone
Copy link

@crozone crozone commented Feb 24, 2020

Adds reference images and a CSV file of reference hashes for those images.

Fixes #38

The hashes were generated from the C implementation of the BlurHash encoder, using the following bash commands:

TESTIMAGES="SomeDirectory/Images/*"

for f in $TESTIMAGES; do for j in {1..8}; do for i in {1..8}; do echo "\"$(basename -- $f)\",$j,$i,\"$(./blurhash $j $i $f)\""; done; done; done

@DagAgren
Copy link
Collaborator

I'm not sure the algorithm is specified quite tightly enough to warrant creating references at the moment. Colour space conversions will affect the result slightly, and there is no specification of what exactly it should be, nor have I checked thoroughly that all implementations are strict enough about it.

The whole algorithm is all about rough approximations anyway, and I am not sure if such strictness is even desirable.

@DagAgren DagAgren mentioned this pull request Feb 24, 2020
@jerry-git jerry-git added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference images and hashes for testing
3 participants