-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sqlite database #5
Conversation
import datetime | ||
import re | ||
|
||
import sqlalchemy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import nitpicks:
- Inconsistent imports here. Maybe add create_engine to line 6 and delete line 5.
- Maybe alphabetize imports for better readability
import unittest | ||
import sys | ||
|
||
sys.path.append("src") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the ideal method, but will work fine if people are using nosetests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay testing! Could you update the readme saying how to run these tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
🚢🚢🚢! 🐱 |
Adds a sqlite database