Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove site-logo support #2146

Merged
merged 2 commits into from
May 15, 2024
Merged

remove site-logo support #2146

merged 2 commits into from
May 15, 2024

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented May 14, 2024

Fixes #2145

This PR fixes #2145. Jetpack deprecated the site-logo functionalities, so this PR removes support for it.

At the same time, it will always be possible to customize the logo given that we already support custom-logo (source code)

Screenshots

How to test the changes in this Pull Request:

  1. Install Jetpack and activate Storefront
  2. Make sure WP_DEBUG is enabled
  3. Refresh the page
  4. Ensure that you don't see any log like this in debug.log:
PHP Deprecated:  Hook site-logo is deprecated since version 13.4! Use custom-logo instead. Jetpack no longer supports site-logo feature. Add custom-logo support to your theme instead: https://developer.wordpress.org/themes/functionality/custom-logo/ in /srv/htdocs/__wp__/wp-includes/functions.php on line 6078

  1. Visit wp-admin/customize.php
  2. Go on Site Identity
  3. Ensure that you can change the logo

Changelog

Fix – Edit, reply and author icons are now displayed in comment list form. #1319

@gigitux gigitux self-assigned this May 14, 2024
@gigitux gigitux requested review from a team and nefeline and removed request for a team May 14, 2024 16:24
Copy link
Contributor

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @gigitux !

Ensured that there are no errors on debug.log and that it is possible to change the site logo.

@github-actions github-actions bot added the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label May 15, 2024
@gigitux gigitux merged commit 95bcf6d into trunk May 15, 2024
7 checks passed
@gigitux gigitux deleted the fix/remove-site-logo-support branch May 15, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack Site logo being deprecated in Jetpack 13.4
2 participants