diff --git a/WooCommerce/src/main/kotlin/com/woocommerce/android/model/SubscriptionDetailsMapper.kt b/WooCommerce/src/main/kotlin/com/woocommerce/android/model/SubscriptionDetailsMapper.kt index 28aa2a340ca..44e7f39361d 100644 --- a/WooCommerce/src/main/kotlin/com/woocommerce/android/model/SubscriptionDetailsMapper.kt +++ b/WooCommerce/src/main/kotlin/com/woocommerce/android/model/SubscriptionDetailsMapper.kt @@ -63,7 +63,7 @@ object SubscriptionDetailsMapper { } private fun WCMetaData.extractPaymentsSyncDate(): SubscriptionPaymentSyncDate? { - return when(isJson) { + return when (isJson) { true -> value.stringValue.let { val jsonObject = JsonParser.parseString(it).asJsonObject val day = jsonObject["day"].asInt diff --git a/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/details/ProductDetailCardBuilder.kt b/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/details/ProductDetailCardBuilder.kt index 151446aaada..13ed2ca0cf2 100644 --- a/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/details/ProductDetailCardBuilder.kt +++ b/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/details/ProductDetailCardBuilder.kt @@ -468,6 +468,7 @@ class ProductDetailCardBuilder( } } + @Suppress("LongMethod") private fun ProductAggregate.shipping(): ProductProperty? { return if (!this.product.isVirtual && hasShipping) { val weightWithUnits = product.getWeightWithUnits(parameters.weightUnit) diff --git a/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/details/ProductDetailViewModel.kt b/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/details/ProductDetailViewModel.kt index 4e7171ff566..11f9669e56f 100644 --- a/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/details/ProductDetailViewModel.kt +++ b/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/details/ProductDetailViewModel.kt @@ -715,7 +715,8 @@ class ProductDetailViewModel @Inject constructor( attributeListViewState = attributeListViewState.copy(progressDialogState = ProgressDialogState.Hidden) } - fun hasCategoryChanges() = storedProductAggregate.value?.product?.hasCategoryChanges(viewState.productDraft) ?: false + fun hasCategoryChanges() = storedProductAggregate.value + ?.product?.hasCategoryChanges(viewState.productDraft) ?: false fun hasTagChanges() = storedProductAggregate.value?.product?.hasTagChanges(viewState.productDraft) ?: false @@ -851,7 +852,8 @@ class ProductDetailViewModel @Inject constructor( ) } - fun hasExternalLinkChanges() = storedProductAggregate.value?.product?.hasExternalLinkChanges(viewState.productDraft) ?: false + fun hasExternalLinkChanges() = storedProductAggregate.value + ?.product?.hasExternalLinkChanges(viewState.productDraft) ?: false /** * Called when the back= button is clicked in a product sub detail screen @@ -1863,7 +1865,8 @@ class ProductDetailViewModel @Inject constructor( triggerEvent(ProductNavigationTarget.RenameProductAttribute(attributeName)) } - fun hasAttributeChanges() = storedProductAggregate.value?.product?.hasAttributeChanges(viewState.productDraft) ?: false + fun hasAttributeChanges() = storedProductAggregate.value + ?.product?.hasAttributeChanges(viewState.productDraft) ?: false /** * Used by the add attribute screen to fetch the list of store-wide product attributes