This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Making filter block contextual on the front end #10919
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
7dc741e
Add collection filters block
roykho 3abd242
Remove frontend script
roykho c8d2b06
use inner blocks hook
dinhtungdu 9554855
Merge branch 'trunk' into filter-collection-block
dinhtungdu 204caca
CollectionFilters: Hydrate Collection Data for inner filter blocks
dinhtungdu dca4d78
wip
dinhtungdu eca8acf
only alter context for filter inner blocks
dinhtungdu c275ea0
cache the current response
dinhtungdu 156089c
fix block list iteration
dinhtungdu e413a30
refactor api hydration
dinhtungdu 6c2f1f8
Merge branch 'trunk' into contextual-filter
dinhtungdu da465c7
map all product collection block query params to product collection d…
dinhtungdu 133790e
support custom taxonomies
dinhtungdu dcb70d5
better explain the logic
dinhtungdu dadcb89
try: process shared params separately
dinhtungdu d6b6ffe
reduce if conditions
dinhtungdu 9fa65fc
try: array walk
dinhtungdu dcfbfd9
Revert "try: array walk"
dinhtungdu de14d21
refactoring
dinhtungdu 96eb82c
use array walk for explicit
dinhtungdu c41ad35
typo
dinhtungdu f58365b
Merge branch 'trunk' into contextual-filter
dinhtungdu 74e7ecd
Merge branch 'trunk' into contextual-filter
dinhtungdu 1ef3280
passing collection data context to filter block only
dinhtungdu 2ece513
Merge branch 'trunk' into contextual-filter
dinhtungdu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function can be refactored into this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this looks better? 🤔 I kinda like the first version with the loop to be honest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the short circuit, I do, but
iterator_to_array()
only accepts arrays from PHP 8.2, so we need that short circuit, which kinda decreases the readability.We can remove the short circuit to make the logic flow less divergent, but I don't really like the inline condition.