This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Gallery block: Move inner block settings around to match the order from the design #11170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thealexandrelara
added
type: bug
woocommercebot
requested review from
a team and
dinhtungdu
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/product-gallery/inner-blocks/product-gallery-thumbnails/edit.tsx
|
|
Size Change: +11 kB (+1%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
dinhtungdu
reviewed
Oct 9, 2023
There was a problem hiding this comment.
@thealexandrelara this PR is testing well, I can confirm the behavior follow the testing steps.
However, the Playwright tests is failing, I retried the test one more time but it still failed. We should check and fix it before merging this PR.
Hey @dinhtungdu, thank you so much for reviewing and approving this. I forgot to comment yesterday that I would be looking at this. It turns out there was just a locator that wasn't correct, but now it's fixed. Thank you again 🙌 |
thealexandrelara
deleted the
fix/11074-move-blocks-settings-to-correct-position
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The current position for the Product Gallery settings are not matching the order from the design, so the idea with this PR is to solve that by putting all settings in the correct order as they appear on the design.
Fixes #11074
Why
To match the design and provide a better user experience.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required: