This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Collection - Fix undefined layout attribute issue in migration #11196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue where layout attributes could become undefined during the block migration process. Alongside this fix, several updates were made to align the migration logic with the new `ProductCollectionDisplayLayout` types: - Added logic to handle `undefined` layout attributes, defaulting to `DEFAULT_ATTRIBUTES.displayLayout`. - Removed `ProductGridLayout` and `ProductGridLayoutTypes` from the types file. - Imported `LayoutOptions` and `ProductCollectionDisplayLayout` from the product-collection module. - Updated the `mapLayoutType` and `mapLayoutPropertiesFrom...` functions to use the new layout types. - Updated transformation functions like `transformProductTemplate` and `transformPostSummary` to use the new types. These changes not only resolve the issue with undefined layout attributes but also align the codebase with the new layout options, enhancing code maintainability.
imanish003
changed the title
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
imanish003
added
focus: blocks
|
Size Change: +136 B (0%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
kmanijak
approved these changes
Oct 10, 2023
imanish003
deleted the
fix/products-to-product-collection-migration-issue
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes an issue where layout attributes could become undefined during block migration from Products to Product Collection
Why
This PR addresses an issue where layout attributes could be undefined during the migration process between the 'Product Collection' and 'Product' blocks. Alongside this crucial fix, the PR aligns the migration logic with the new
ProductCollectionDisplayLayouttypes to improve code maintainability.This was reported by Tom on Slack - p1696933396571839-slack-C02FL3X7KR6
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Products (Beta) blockand then clickUpgrade to Product Collectionin the block inspector sidebar.Upgrade to Product Collectionworks & convertProducts (Beta) blocktoProduct CollectionblockScreenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog